Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gtdb-tk #6337

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Update gtdb-tk #6337

merged 3 commits into from
Sep 25, 2024

Conversation

paulzierep
Copy link
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

column="2" starts counting on 0
with the new loc.test file, you can test this behavior and the regex when serving locally

@bernt-matthias
Copy link
Contributor

Few points:

  • we need to bump
  • do you think it would be a good idea to use the column name instead (should work according to the docs). I think it would be better.
  • Have you tested this locally?

@bernt-matthias bernt-matthias mentioned this pull request Sep 18, 2024
Merged
4 tasks
@paulzierep
Copy link
Contributor Author

Column name works. I have tested it locally in the sense, that serving the tool with planemo allows selecting the test DB. But I did not test with a full DB, since I do not have the space on my disc :)

@bebatut bebatut merged commit 0f5d58e into galaxyproject:main Sep 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulzierep @bernt-matthias @bgruening @bebatut